Skip to content

feat(drag-drop): allow for dragging sequence to be delayed #14732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 5, 2019

Adds the cdkDragStartDelay input that allows for the dragging sequence to be delayed by X amount of milliseconds.

Fixes #13908.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Jan 5, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 5, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation?

@crisbeto
Copy link
Member Author

crisbeto commented Jan 9, 2019

@jelbourn it's added to the API docs. I can add a live example in a follow-up.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@crisbeto crisbeto force-pushed the 13908/drag-start-delay branch 2 times, most recently from 46a35c6 to 6ac4537 Compare January 17, 2019 23:12
@ngbot
Copy link

ngbot bot commented Jan 25, 2019

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 13908/drag-start-delay branch from 6ac4537 to 7ff42a8 Compare January 27, 2019 17:22
@jelbourn
Copy link
Member

jelbourn commented Feb 7, 2019

@crisbeto this passes presubmit, just looks like the api gold needs an update

Adds the `cdkDragStartDelay` input that allows for the dragging sequence to be delayed by X amount of milliseconds.

Fixes angular#13908.
@crisbeto crisbeto force-pushed the 13908/drag-start-delay branch from 7ff42a8 to 2d87a11 Compare February 9, 2019 11:11
@crisbeto
Copy link
Member Author

crisbeto commented Feb 9, 2019

Fixed the issue with the golden check.

@jelbourn jelbourn merged commit bcf2781 into angular:master Feb 22, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 2, 2019
Adds some docs and a live example for the `cdkDragStartDelay` input. Follow-up from angular#14732.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 13, 2019
Adds some docs and a live example for the `cdkDragStartDelay` input. Follow-up from angular#14732.
mmalerba pushed a commit that referenced this pull request Apr 2, 2019
Adds some docs and a live example for the `cdkDragStartDelay` input. Follow-up from #14732.

**Note:** targeting `major`, because the PR that introduces the functionality was merged into the next major branch.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to delay dragging event by X milliseconds
3 participants