Skip to content

feat(dialog): add ariaLabelledBy config option #14943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

jtcrowson
Copy link

This change adds the ability to manually set the aria-labelledby attribute of a MatDialog.

Users can set the aria-labelledby without the mat-dialog-title directive. Users can provide multiple id's.

It is described as an attribute of MatDialogConfig in the Dialog Accessibility Documentation, but is not implemented. This was also mentioned as a follow up to #5176 (comment).

No breaking changes. Existing functionality is preserved without setting the ariaLabelledBy config attribute.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2019
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit.

@crisbeto crisbeto added pr: lgtm target: minor This PR is targeted for the next minor release labels Jan 27, 2019
@jtcrowson jtcrowson force-pushed the dialog-aria-labelledby-config branch 2 times, most recently from ba0b96e to 01bc7ae Compare January 28, 2019 17:34
this change adds the ability to set the `aria-labelledby` of a dialog. user can customize the `aria-labelledby` without mat-dialog-title.

no breaking changes.  existing functionality is preserved without setting the ariaLabelledBy config option.
@jtcrowson jtcrowson force-pushed the dialog-aria-labelledby-config branch from 01bc7ae to 557ef14 Compare January 28, 2019 18:05
@jtcrowson
Copy link
Author

@crisbeto fixed your comment. Anything I need to fix to get the branch-manager passing? I have already rebased.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2019
@ngbot
Copy link

ngbot bot commented Jan 29, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
Copy link
Member

crisbeto commented Jan 29, 2019

Nope, that failing CI check will be sorted out by the caretaker.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 3e935e9 into angular:master Feb 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants