feat(sticky-header): add app-demo for sticky-header #5176
Conversation
add chose parent add support to 'optional 'cdkStickyRegion' input '
googlebot
added
the
cla: yes
tinayuangao
changed the title
| templateUrl: 'sticky-header-demo.html', | ||
| styleUrls: ['sticky-header-demo.css'], | ||
| }) | ||
|
|
There was a problem hiding this comment.
nit: remove the empty lines
| import {NgModule} from '@angular/core'; | ||
| import {BrowserModule} from '@angular/platform-browser'; | ||
| import {StickyParentDirective, StickyHeaderDirective} from '@angular/material'; | ||
| export {StickyParentDirective, StickyHeaderDirective}; |
There was a problem hiding this comment.
Don't need to export them
| @@ -0,0 +1,20 @@ | |||
| import {Component} from '@angular/core'; | |||
| import {NgModule} from '@angular/core'; | |||
| import {BrowserModule} from '@angular/platform-browser'; | |||
There was a problem hiding this comment.
This and NgModule import can be removed
| }) | ||
|
|
||
|
|
||
| export class StickyHeaderDemo { |
There was a problem hiding this comment.
Remove constructor
export class StickyHeaderDemo {}
| <h1>Sticky-header Demo</h1> | ||
| <div id="testFor" class="container"> | ||
|
|
||
| <div id="theStickyHeaderLalala" style="margin: 0; border: 0; padding: 0;"> |
There was a problem hiding this comment.
Move styles to css class if possible.
Remove the id if it's not needed
| } | ||
|
|
||
|
|
||
| h2 { |
There was a problem hiding this comment.
add class for these elements? h2, p, and div
modify
fix some code according to PR review comments
|
closed by accident... |
tinayuangao
force-pushed
the
sticky-header
branch
from
ea9651b to
279983b
Compare
.firebaserc
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| -moz-appearance: none; | ||
| } | ||
|
|
||
| p { |
There was a problem hiding this comment.
Can we use class for p h2 div body header *?
There was a problem hiding this comment.
Put class for p h2 div body header * into 'democlass' class 👍
sllethe
force-pushed
the
sticky-header
branch
2 times, most recently
from
750b8f9 to
b018f26
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.