feat(sticky-header): Initial version of sticky header #5175

sllethe · 2017-06-16T21:19:08Z

add support to 'optional 'cdkStickyRegion' input '

tinayuangao

Initial pass

tinayuangao · 2017-06-16T21:25:45Z

src/lib/sticky-header/sticky-header-dir.ts

+
+
+@Directive({
+    selector: '[md-sticky-viewport], [cdkStickyViewport], [cdkStickyRegion]',


You can remove [md-sticky-viewport] and [cdkStickyViewport].

tinayuangao · 2017-06-16T21:26:32Z

src/lib/sticky-header/sticky-header-dir.ts

+@Directive({
+    selector: '[md-sticky-viewport], [cdkStickyViewport], [cdkStickyRegion]',
+})
+


nit: remove empty lines so it's clear that selector cdkStickyRegion is associated with StickyParentDirective

tinayuangao · 2017-06-16T21:26:48Z

src/lib/sticky-header/sticky-header-dir.ts

+})
+
+
+@Injectable()


Do we need this injectable?

Right~ We don't need @Injectable for StickyParentDirective.

tinayuangao · 2017-06-16T21:27:28Z

src/lib/sticky-header/sticky-header-dir.ts

+export class StickyParentDirective implements OnInit, OnDestroy, AfterViewInit {
+
+    // The parent element, which with the 'md-sticky-viewport' tag
+    private pelem: any;


This variable can be removed

tinayuangao · 2017-06-16T21:28:47Z

src/lib/sticky-header/sticky-header-dir.ts

+    }
+
+    ngOnInit(): void {
+        this.pelem.classList.add('sticky-parent');


Do we need this class? You can get the parent element by injection.

Removed OnInit, AfterViewInit and onDestory class. Because we don't need them.

tinayuangao · 2017-06-16T22:17:30Z

src/lib/sticky-header/sticky-header-dir.ts

+    private width: string = 'auto';
+
+    constructor(private element: ElementRef,
+                public findScroll: Scrollable,


scrollable

tinayuangao · 2017-06-16T22:21:39Z

src/lib/sticky-header/sticky-header-dir.ts

@@ -0,0 +1,334 @@
+import {


nit: 2 space for indent

tinayuangao · 2017-06-16T22:26:26Z

src/lib/sticky-header/sticky-header-dir.ts

+        // detecting when a container's height changes
+        let currentContainerHeight: number = this.getCssNumber(this.stickyParent, 'height');
+        if (currentContainerHeight !== this.containerHeight) {
+            this.defineRestrictions();


Usually defineRestrictions() are called before sticker(). Do you still need this?

Deleted checking currentContainerHeight in sticker(). Because we always call defineRestrictions() before sticker().

tinayuangao · 2017-06-16T22:28:05Z

src/lib/sticky-header/sticky-header-dir.ts

+        }
+
+        this.defineRestrictions();
+        this.sticker();


Combine defineRestrictions and sticker?

defineRestrictionsAndStick()

Combined defineRestrictions() and sticker() as defineRestrictionsAndStick()

tinayuangao · 2017-06-16T22:28:49Z

src/lib/sticky-header/sticky-header-dir.ts

+        this.upperScrollableContainer.addEventListener('touchmove', this.onTouchMoveBind, false);
+
+        Observable.fromEvent(this.upperScrollableContainer, 'scroll')
+            .subscribe(() => this.onScroll());


Can be

Observable.fromEvent(this.upperScrollableContainer, 'scroll') .subscribe(() => this.defineRestrictionsAndStick());

googlebot · 2017-06-21T01:15:09Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

add chose parent add support to 'optional 'cdkStickyRegion' input ' add app-demo for sticky-header fix bugs and deleted unused tag id in HTML files modify

googlebot · 2017-06-21T16:54:29Z

CLAs look good, thanks!

change some format to pass TSlint check

add '_' before private elements

@Injectable

delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable

refine code

tinayuangao · 2017-06-21T21:31:40Z

.firebaserc

@@ -0,0 +1,5 @@
+{


? revert this file

tinayuangao · 2017-06-21T21:32:38Z

src/demo-app/demo-app-module.ts

@@ -74,9 +74,11 @@ import {
  MdToolbarModule,
  MdTooltipModule,
  OverlayContainer,
-  StyleModule
+  StyleModule,
+  MdStickyHeaderModule,


Did you put demo related part in #5176? You can remove that part from this PR

removed demo code

tinayuangao · 2017-06-21T21:43:16Z

src/lib/sticky-header/index.ts

+    declarations: [StickyParentDirective, StickyHeaderDirective],
+    exports: [StickyParentDirective, StickyHeaderDirective, MdCommonModule],
+})
+export class MdStickyHeaderModule {}


call it CdkStickyHeaderModule?

tinayuangao · 2017-06-21T21:43:55Z

src/lib/sticky-header/sticky-header-dir.ts

+@Directive({
+    selector: '[cdkStickyRegion]',
+})
+export class StickyParentDirective {


CdkStickyRegion

Add docs for this directive?

tinayuangao · 2017-06-21T21:54:17Z

src/lib/sticky-header/sticky-header-dir.ts

+})
+
+@Injectable()
+export class StickyHeaderDirective implements OnDestroy, AfterViewInit {


Change the name to CdkStickyHeader?

tinayuangao · 2017-06-21T22:23:57Z

src/lib/sticky-header/sticky-header-dir.ts

+    public originalCss: any;
+
+    // the height of 'stickyParent'
+    public containerHeight: number;


This can be local

tinayuangao · 2017-06-21T22:25:25Z

src/lib/sticky-header/sticky-header-dir.ts

+        this.elem.style.position = 'fixed';
+        this.elem.style.top = this.getCssNumber(this.upperScrollableContainer, 'top') + 'px';
+
+        this._scrollingRight = this.upperScrollableContainer.offsetLeft +


Where is this _scrollingRight used?

deleted _scrollingRight

tinayuangao · 2017-06-21T22:26:00Z

src/lib/sticky-header/sticky-header-dir.ts

+    private _scrollingRight: number;
+
+    // the padding of 'elem'
+    private _elementPadding: any;


Can be a local variable

tinayuangao · 2017-06-21T22:26:21Z

src/lib/sticky-header/sticky-header-dir.ts

+
+    // the padding of 'elem'
+    private _elementPadding: any;
+    private _paddingNumber: number;


Can be a local variable

tinayuangao · 2017-06-21T22:28:59Z

src/lib/sticky-header/sticky-header-dir.ts

+    }
+
+
+    sticker(): void {


encapsulate 'set style for element'

Added reference link to Modernizer in docs of getSupportList()

Deleted "_supportList" variable

renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable

Set debounce time as a const variable

Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'

@param

Removed the @param and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function

sllethe

Comments Addressed. Please take another look 👍

sllethe · 2017-07-15T01:07:46Z

src/lib/sticky-header/sticky-header-dir.ts

+@Directive({
+  selector: '[cdkStickyHeader]',
+})
+/**


Moved docs above @directive 👍

sllethe · 2017-07-15T01:10:12Z

src/lib/sticky-header/sticky-header-dir.ts

+   */
+  private _supportList: Array<string>;
+
+  constructor(_element: ElementRef,


removed the underscore in _element: ElementRef,

sllethe · 2017-07-15T01:12:34Z

src/lib/sticky-header/sticky-header-dir.ts

+
+  constructor(_element: ElementRef,
+              scrollable: Scrollable,
+              @Optional() public parentReg: CdkStickyRegion) {


Yes. It's short for region. Expanded~

sllethe · 2017-07-15T01:14:24Z

src/lib/sticky-header/sticky-header-dir.ts

+  }
+
+  ngAfterViewInit(): void {
+    if(this.isIE === true) {


sllethe · 2017-07-15T01:17:18Z

src/lib/sticky-header/sticky-header-dir.ts

+    if(this.isIE === true) {
+      this.stickyParent = this.parentReg != null ?
+        this.parentReg._elementRef.nativeElement : this.element.parentElement;
+      this.originalCss = this.generateCssStyle(this.getCssValue(this.element, 'zIndex'),


added more newlines between params

sllethe · 2017-07-17T17:34:08Z

src/lib/sticky-header/sticky-header-dir.ts

+
+  attach() {
+    this._onScrollSubscription =  Observable.fromEvent(this.upperScrollableContainer, 'scroll')
+      .debounceTime(5).subscribe(() => this.defineRestrictionsAndStick());


Set debounce time as a const variable and added docs to explain why it is 5.

sllethe · 2017-07-17T17:35:18Z

src/lib/sticky-header/sticky-header-dir.ts

+   * when to start, when to finish)
+   */
+  defineRestrictions(): void {
+    if(this.stickyParent == null) {


sllethe · 2017-07-17T17:38:34Z

src/lib/sticky-header/sticky-header-dir.ts

+
+  /**
+   * This function is used to generate a variable which contains 7 css styles.
+   * @param zIndex


Removed the @param and @returns and make sure the types are correct in the function signature

sllethe · 2017-07-17T17:39:26Z

src/lib/sticky-header/sticky-header-dir.ts

+   */
+  generateCssStyle(zIndex:any, position:any, top:any, right:any,
+                   left:any, bottom:any, width:any): any {
+    let targetCSS = {


sllethe · 2017-07-17T17:39:59Z

src/lib/sticky-header/sticky-header-dir.ts

+   */
+  generateCssStyle(zIndex:any, position:any, top:any, right:any,
+                   left:any, bottom:any, width:any): any {
+    let targetCSS = {


returned targetCSS;

tinayuangao · 2017-07-17T19:36:18Z

src/lib/sticky-header/sticky-header-dir.ts

+   */
+  setStrategyAccordingToCompatibility(): void {
+    let supportList = this.getSupportList();
+    if(supportList.length == 0) {


nit: add space between if and (. Use ===

tinayuangao · 2017-07-17T19:36:43Z

src/lib/sticky-header/sticky-header-dir.ts

+    let supportList = this.getSupportList();
+    if(supportList.length == 0) {
+      this.isStickyPositionSupported = true;
+    }else {


nit: add space between } and else

tinayuangao · 2017-07-17T19:38:58Z

src/lib/sticky-header/sticky-header-dir.ts

+    let supportList: Array<string> = new Array<string>();
+    let stickyText = '';
+    for (let i = 0; i < prefixTestList.length; i++ ) {
+      stickyText += 'position:' + prefixTestList[i] + 'sticky;';


Why do you need += here? Add comments?

Nope~ Do not need +=, should use =.

tinayuangao · 2017-07-17T19:40:58Z

src/lib/sticky-header/sticky-header-dir.ts

+  private _onResizeBind: EventListener = this.onResize.bind(this);
+  private _onTouchMoveBind: EventListener = this.onTouchMove.bind(this);
+  isStuck: boolean = false;
+  isStickyPositionSupported: boolean = false;


Add docs about this variable.
Is true means position: sticky supported?

Added docs for isStickyPositionSupported variable

tinayuangao · 2017-07-17T19:41:34Z

src/lib/sticky-header/sticky-header-dir.ts

+    if(supportList.length == 0) {
+      this.isStickyPositionSupported = true;
+    }else {
+      let prefix: string = supportList[0];


Only need supportList[0]? Add comments

Yes. Because supportList contains all the prefix that can make sticky positioning work in the current browser. We only need to get one prefix and make position: prefix + 'sticky', then sticky position will work.
Added comments

Added docs for `isStickyPositionSupported` variable

changed '+=' to '=' of 'stickyText' in getSupportList() function

nit added " " between 'if' and '('

Added comments

sllethe · 2017-07-17T20:21:12Z

Comments Addressed. 👍
Please take another look~

jelbourn · 2017-07-17T20:00:18Z

src/lib/sticky-header/index.ts

+  declarations: [CdkStickyRegion, CdkStickyHeader],
+  exports: [CdkStickyRegion, CdkStickyHeader, MdCommonModule],
+})
+export class StickyHeaderModule {}


Just noticed that all this code is in src/lib. As part of the cdk, it should all be under src/cdk. You could do this in a another PR after this one.

jelbourn · 2017-07-17T20:10:47Z

src/lib/sticky-header/sticky-header-dir.ts

+}
+
+
+// STICK_START_CLASS is used to mark a header is stuck.


/** Class applied when the header is "stuck" */

/** Class applied when the header is not "stuck" */

jelbourn · 2017-07-17T20:12:57Z

src/lib/sticky-header/sticky-header-dir.ts

+   * or 'position: -webkit-sticky'.
+   * isStickyPositionSupported == false, means current browser does not support sticky
+   * positioning and need to use the original implementation to get the sticky effect.
+   * @type {boolean}


Omit type from JsDoc

jelbourn · 2017-07-17T20:13:50Z

src/lib/sticky-header/sticky-header-dir.ts

+   * isStickyPositionSupported == true, means current browser support 'position: sticky'
+   * or 'position: -webkit-sticky'.
+   * isStickyPositionSupported == false, means current browser does not support sticky
+   * positioning and need to use the original implementation to get the sticky effect.


This whole comment can be shortened to
Whether the browser support CSS sticky positioning.

jelbourn · 2017-07-17T20:17:36Z

src/lib/sticky-header/sticky-header-dir.ts

+import {Subscription} from 'rxjs/Subscription';
+import 'rxjs/add/observable/fromEvent';
+import 'rxjs/add/operator/debounceTime';
+import {createElement} from "@angular/core/src/view/element";


Deep imports into @angular/core are not allowed

import {createElement} from "@angular/core/src/view/element";
I found that this import is actually unused. I just deleted it~

jelbourn · 2017-07-17T20:30:44Z

src/lib/sticky-header/sticky-header-dir.ts

+   * (https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/positionsticky.js).
+   */
+  getSupportList(): Array<string> {
+    let prefixTestList = ['', '-webkit-', '-ms-', '-moz-', '-o-'];


Can we just create a CSS class that has all of these applied and use that in the support check?

Also, I don't think moz and ms are necessary. Do you have a resource for this?

We can not add css class. Because sticky-header is a @Directive instead of a @Component. So we can not be able to apply styleURLs: xxx.css on it. So I just directly changed it's css style in code.

jelbourn · 2017-07-17T20:31:37Z

src/lib/sticky-header/sticky-header-dir.ts

+      let body = document.body;
+      div.style.cssText = 'display:none;' + stickyText;
+      body.appendChild(div);
+      let isSupport = /sticky/i.test(window.getComputedStyle(div).position);


We should ensure that this call to getComputedStyle happens at the same time as other getComputedStyle calls

If we found that the current browser support sticky positioning. The original implementation of sticky-header will not be called, which means we will not call the rest of the getComputedStyle if the current browser support sticky positioning.
The rest getComputedStyle will only be called when the in-build sticky positioning is not supported.

jelbourn · 2017-07-17T20:33:04Z

src/lib/sticky-header/sticky-header-dir.ts

+   * The implementation references the compatibility checking in Modernizer
+   * (https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/positionsticky.js).
+   */
+  getSupportList(): Array<string> {


This check needs to be gated on whether or not we're on the browser (and not rendering with platform-server)

Added check whether we're on the browser

jelbourn · 2017-07-17T20:37:40Z

src/lib/sticky-header/sticky-header-dir.ts

+  }
+
+  onResize(): void {
+    this.defineRestrictionsAndStick();


If you're going to unstick on resize, why call this at all?

Because I need to judge whether the current header need to be stuck. Calling defineRestrictionsAndStick() to see the current state of the header. If the current header is stuck, we need to unstuck it and then stuck it again to reshape the sticky header. And if the current header is not stuck, we will do nothing. Just let it being scrolled up or down.

jelbourn · 2017-07-17T20:38:42Z

src/lib/sticky-header/sticky-header-dir.ts

+    this._containerStart = containerTop.top;
+
+    // the padding of the element being stuck
+    let paddingNumber: any = Number(this.padding.slice(0, -2));


parseInt automatically ignores trailing non-numeric characters

Found paddingNumber is unecessary. Deleted this global variable.

deleted unused import

change comments

optimize comments

deleted unnecessary global variables(padding and stickyRegionHeight)

sllethe

Comments Addressed. Please take another look. 👍
And I'll create a new PR to move all the code to 'src/cdk'

sllethe · 2017-07-17T20:59:07Z

src/lib/sticky-header/sticky-header-dir.ts

+import {Subscription} from 'rxjs/Subscription';
+import 'rxjs/add/observable/fromEvent';
+import 'rxjs/add/operator/debounceTime';
+import {createElement} from "@angular/core/src/view/element";


import {createElement} from "@angular/core/src/view/element";
I found that this import is actually unused. I just deleted it~

sllethe · 2017-07-17T21:00:15Z

src/lib/sticky-header/sticky-header-dir.ts

+}
+
+
+// STICK_START_CLASS is used to mark a header is stuck.


sllethe · 2017-07-17T21:00:26Z

src/lib/sticky-header/sticky-header-dir.ts

+ * be one sticky-header in one 'cdkStickyRegion'.
+ * If a user does not define a 'cdkStickyRegion' for a sticky-header, the direct
+ * parent node of the sticky-header will be set as the 'cdkStickyRegion'.
+ */


sllethe · 2017-07-17T21:01:16Z

src/lib/sticky-header/sticky-header-dir.ts

+   * isStickyPositionSupported == true, means current browser support 'position: sticky'
+   * or 'position: -webkit-sticky'.
+   * isStickyPositionSupported == false, means current browser does not support sticky
+   * positioning and need to use the original implementation to get the sticky effect.


sllethe · 2017-07-17T21:02:41Z

src/lib/sticky-header/sticky-header-dir.ts

+   * or 'position: -webkit-sticky'.
+   * isStickyPositionSupported == false, means current browser does not support sticky
+   * positioning and need to use the original implementation to get the sticky effect.
+   * @type {boolean}


sllethe · 2017-07-18T18:15:59Z

src/lib/sticky-header/sticky-header-dir.ts

+   * The implementation references the compatibility checking in Modernizer
+   * (https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/positionsticky.js).
+   */
+  getSupportList(): Array<string> {


sllethe · 2017-07-18T18:20:06Z

src/lib/sticky-header/sticky-header-dir.ts

+   * (https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/positionsticky.js).
+   */
+  getSupportList(): Array<string> {
+    let prefixTestList = ['', '-webkit-', '-ms-', '-moz-', '-o-'];


We can not add css class. Because sticky-header is a @Directive instead of a @Component. So we can not be able to apply styleURLs: xxx.css on it. So I just directly changed it's css style in code.

sllethe · 2017-07-18T19:44:02Z

src/lib/sticky-header/sticky-header-dir.ts

+   * The implementation references the compatibility checking in Modernizer
+   * (https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/positionsticky.js).
+   */
+  getSupportList(): Array<string> {


Added check whether we're on the browser

sllethe · 2017-07-18T19:53:36Z

src/lib/sticky-header/sticky-header-dir.ts

+      let body = document.body;
+      div.style.cssText = 'display:none;' + stickyText;
+      body.appendChild(div);
+      let isSupport = /sticky/i.test(window.getComputedStyle(div).position);


If we found that the current browser support sticky positioning. The original implementation of sticky-header will not be called, which means we will not call the rest of the getComputedStyle if the current browser support sticky positioning.
The rest getComputedStyle will only be called when the in-build sticky positioning is not supported.

sllethe · 2017-07-18T19:56:43Z

src/lib/sticky-header/sticky-header-dir.ts

+  }
+
+  onResize(): void {
+    this.defineRestrictionsAndStick();


Because I need to judge whether the current header need to be stuck. Calling defineRestrictionsAndStick() to see the current state of the header. If the current header is stuck, we need to unstuck it and then stuck it again to reshape the sticky header. And if the current header is not stuck, we will do nothing. Just let it being scrolled up or down.

angular-automatic-lock-bot · 2019-09-06T17:02:14Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 16, 2017

tinayuangao self-requested a review June 16, 2017 21:20

tinayuangao self-assigned this Jun 16, 2017

tinayuangao changed the title ~~PR for 'src/lib/sticky-header' files~~ feat(sticky-header): Initial version of sticky header Jun 16, 2017

tinayuangao reviewed Jun 16, 2017

View reviewed changes

sllethe force-pushed the sticky-header branch from ab4fd94 to d92fd65 Compare June 21, 2017 01:14

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jun 21, 2017

sllethe force-pushed the sticky-header branch from d92fd65 to 3851c8a Compare June 21, 2017 16:51

sllethe added 2 commits June 21, 2017 09:54

add lib files for sticky-header

f261b98

add chose parent add support to 'optional 'cdkStickyRegion' input ' add app-demo for sticky-header fix bugs and deleted unused tag id in HTML files modify

fix some code according to PR review comments

5393e6a

sllethe force-pushed the sticky-header branch from 3851c8a to 5393e6a Compare June 21, 2017 16:54

googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jun 21, 2017

tinayuangao requested a review from andrewseguin June 21, 2017 18:11

tinayuangao assigned andrewseguin Jun 21, 2017

tinayuangao requested a review from jelbourn June 21, 2017 18:11

tinayuangao assigned jelbourn, tinayuangao and andrewseguin and unassigned tinayuangao and andrewseguin Jun 21, 2017

sllethe added 4 commits June 21, 2017 14:19

38c7d72

change some format to pass TSlint check

aff4169

add '_' before private elements

ce0a168

delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable

60f5087

refine code

tinayuangao reviewed Jun 21, 2017

View reviewed changes

c56679e

encapsulate 'set style for element'

sllethe added 7 commits July 17, 2017 09:56

3dcb0c6

Added reference link to Modernizer in docs of getSupportList()

ea2584f

Deleted "_supportList" variable

1f3724e

renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable

604db11

Set debounce time as a const variable

Added docs for 'const DEBOUNCE_TIME: number = 5;'

a76e3ba

349abe1

Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'

2293d8f

Removed the @param and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function

sllethe commented Jul 17, 2017

View reviewed changes

tinayuangao reviewed Jul 17, 2017

View reviewed changes

sllethe added 5 commits July 17, 2017 13:00

6b8d5eb

Added docs for `isStickyPositionSupported` variable

7453869

changed '+=' to '=' of 'stickyText' in getSupportList() function

8e221a3

nit added " " between 'if' and '('

nit

f154e03

9164c37

Added comments

jelbourn reviewed Jul 17, 2017

View reviewed changes

sllethe added 6 commits July 17, 2017 13:58

6511ebb

deleted unused import

867283a

change comments

29177a5

optimize comments

bb655ae

deleted unnecessary global variables(padding and stickyRegionHeight)

Added check whether we are on browser

8a58865

Array<string> to string[]

3f404dc

sllethe commented Jul 18, 2017

View reviewed changes

sllethe merged commit 3f404dc into angular:sticky-header Jul 18, 2017

This was referenced Jul 18, 2017

feat(sticky-header): Initial version of sticky header new PR #5853

Closed

feat(sticky-header): Initial version of sticky header new PR #5857

Merged

feat(sticky-header): Initial version of sticky header new PRNew Sticky header #5858

Merged

angular-automatic-lock-bot bot unassigned tinayuangao Sep 6, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019



		@Directive({
		selector: '[md-sticky-viewport], [cdkStickyViewport], [cdkStickyRegion]',

		})


		@Injectable()

feat(sticky-header): Initial version of sticky header #5175

feat(sticky-header): Initial version of sticky header #5175

Uh oh!

Conversation

sllethe commented Jun 16, 2017

Uh oh!

tinayuangao left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

googlebot commented Jun 21, 2017

Uh oh!

googlebot commented Jun 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sllethe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!