-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(sticky-header): Initial version of sticky header #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
f261b98
add lib files for sticky-header
sllethe 5393e6a
fix some code according to PR review comments
sllethe 38c7d72
aff4169
ce0a168
60f5087
c56679e
d6f44c2
9b41309
e702233
add const STICK_START_CLASS and STICK_END_CLASS
sllethe 0be8e95
ecb2f80
7557e4d
3f0ae25
bd933ab
delete global variable '_width'
sllethe 935ac47
6d3c363
fe294ce
71b36fb
dfeef98
2bdec3a
3b30b89
2c99a85
86493e9
6af9bb9
1feea54
revert demo-app-module.ts
sllethe 7427dd1
cf15f8f
8e5e006
change 'CdkStickyHeaderModule' to 'StickyHeaderModule'
sllethe ea9651b
98ee5c0
0227a46
d937858
abbb192
a307fef
118dca2
9a4c595
412e673
created a generateStyleCSS() function, let it be responsible for gene…
sllethe eaaa591
3b617bf
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
sllethe 72dbb6c
8b07f0c
removed unused import
sllethe da317e6
87d3dd7
removed commented lines
sllethe ccc6865
a718db2
2813368
c2b28ea
f3409ee
128bbe1
013bb2f
d2f78b2
ef9b563
Added comments for STICK_START_CLASS and STICK_END_CLASS.
sllethe e9de5b9
b6d3508
unsubscribe sbscriptions onDestory
sllethe cfa58aa
975f860
0c0ad1b
203e1ee
5e9d613
aaaeb83
7ef3841
3dcb0c6
ea2584f
1f3724e
604db11
a76e3ba
Added docs for 'const DEBOUNCE_TIME: number = 5;'
sllethe 349abe1
2293d8f
6b8d5eb
7453869
8e221a3
f154e03
nit
sllethe 9164c37
6511ebb
867283a
29177a5
bb655ae
8a58865
Added check whether we are on browser
sllethe 3f404dc
Array<string> to string[]
sllethe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* @license | ||
* Copyright Google Inc. All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
import {NgModule} from '@angular/core'; | ||
import {CommonModule} from '@angular/common'; | ||
import {OverlayModule, MdCommonModule} from '../core'; | ||
import {CdkStickyRegion, CdkStickyHeader} from './sticky-header-dir'; | ||
|
||
|
||
|
||
@NgModule({ | ||
imports: [OverlayModule, MdCommonModule, CommonModule], | ||
declarations: [CdkStickyRegion, CdkStickyHeader], | ||
exports: [CdkStickyRegion, CdkStickyHeader, MdCommonModule], | ||
}) | ||
export class StickyHeaderModule {} | ||
|
||
|
||
export * from './sticky-header-dir'; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that all this code is in
src/lib
. As part of the cdk, it should all be undersrc/cdk
. You could do this in a another PR after this one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍