refactor(stepper): remove dependency on @angular/forms #15134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I think this is technically a breaking change. Anyone who is extending and trying to use other properties of AbstractControl in their derived class would need to add a line re-declaring the property. I also just wonder if this is really worth it, I would expect the CDK to have other forms related stuff in the future (e.g. some common component for displaying error messages) |
|
I can expand the typing to include the rest of the properties from |
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto actually, can you update the Caretaker note: we need to remove this dependency in the Google build file as well |
While looking at angular#15085, I noticed that the only place in the CDK where we use `@angular/forms` is to type an optional input in the stepper. These changes replace the typing with a partial representation of the `AbstractControl` so that we can drop the dependency.
crisbeto
force-pushed
the
cdk-forms-dependency
branch
from
5014a46 to
5189898
Compare
josephperrott
pushed a commit
that referenced
this pull request
Mar 5, 2019
While looking at #15085, I noticed that the only place in the CDK where we use `@angular/forms` is to type an optional input in the stepper. These changes replace the typing with a partial representation of the `AbstractControl` so that we can drop the dependency.
|
Unannounced breaking change. Thanks for that! |
Closed
|
@rcketscientist the assumption was that it shouldn't be a breaking change and none of the apps in Google that use Material hit the issue. What error did you get? |
|
As you mentioned in the PR it didn't map the full API. We use CDK extensively for many material-like widgets that have slightly different functionality/styling. |
|
I see. I'll submit a hotfix for it. Sorry for the breaking change. |
|
Much appreciated :) |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 13, 2019
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change. Fixes angular#15462.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 13, 2019
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change. Fixes angular#15462.
mmalerba
pushed a commit
that referenced
this pull request
Mar 13, 2019
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change. Fixes #15462.
mmalerba
pushed a commit
that referenced
this pull request
Mar 13, 2019
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change. Fixes #15462.
mmalerba
pushed a commit
that referenced
this pull request
Mar 18, 2019
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change. Fixes #15462.
|
Thanks for the lightning fast patch guys! |
Suresh918
pushed a commit
to Suresh918/material2
that referenced
this pull request
Apr 15, 2019
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change. Fixes angular#15462.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 24, 2019
…pe checking Before angular#15134 landed, the stepper accepted an`AbstractControl` from `@angular/forms`. Unfortunately this PR accidentally changed the type for the `stepControl` input from `AbstractControl` to `FormControl`. This means that with strict template type checking, passing a `FormGroup` (like we do in our dev-app various times) causes type check failures. We need to adjust the `stepControl` type to accept an abstract control which is the base of a `FormControl` and `FormmGroup`.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 24, 2019
…pe checking Before angular#15134 landed, the stepper accepted an`AbstractControl` from `@angular/forms`. Unfortunately this PR accidentally changed the type for the `stepControl` input from `AbstractControl` to `FormControl`. This means that with strict template type checking, passing a `FormGroup` (like we do in our dev-app various times) causes type check failures. We need to adjust the `stepControl` type to accept an abstract control which is the base of a `FormControl` and `FormmGroup`.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 24, 2019
…pe checking Before angular#15134 landed, the stepper accepted an`AbstractControl` from `@angular/forms`. Unfortunately this PR accidentally changed the type for the `stepControl` input from `AbstractControl` to `FormControl`. This means that with strict template type checking, passing a `FormGroup` (like we do in our dev-app various times) causes type check failures. We need to adjust the `stepControl` type to accept an abstract control which is the base of a `FormControl` and `FormmGroup`.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 25, 2019
…pe checking Before angular#15134 landed, the stepper accepted an`AbstractControl` from `@angular/forms`. Unfortunately this PR accidentally changed the type for the `stepControl` input from `AbstractControl` to `FormControl`. This means that with strict template type checking, passing a `FormGroup` (like we do in our dev-app various times) causes type check failures. We need to adjust the `stepControl` type to accept an abstract control which is the base of a `FormControl` and `FormmGroup`.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 26, 2019
…pe checking Before angular#15134 landed, the stepper accepted an`AbstractControl` from `@angular/forms`. Unfortunately this PR accidentally changed the type for the `stepControl` input from `AbstractControl` to `FormControl`. This means that with strict template type checking, passing a `FormGroup` (like we do in our dev-app various times) causes type check failures. We need to adjust the `stepControl` type to accept an abstract control which is the base of a `FormControl` and `FormmGroup`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #15085, I noticed that the only place in the CDK where we use
@angular/formsis to type an optional input in the stepper. These changes replace the typing with a partial representation of theAbstractControlso that we can drop the dependency.