chore(e2e): break up E2eMaterialModules #15633
Conversation
mmalerba
added
P2
mmalerba
requested review from
crisbeto,
devversion and
josephperrott
as code owners
googlebot
added
the
cla: yes
| </div> | ||
| `, | ||
| styles: [` | ||
| .label { |
There was a problem hiding this comment.
Could we prefix these classes with e2e-?
There was a problem hiding this comment.
I copied this from Andrew's example viewer in the dev-app, it looks like we don't need any of the styles for the e2e app so I removed them
| import {createCustomElement} from '@angular/elements'; | ||
| import {EXAMPLE_COMPONENTS} from '@angular/material-examples'; | ||
|
|
||
| @Component({ |
This change brings the e2e app more inline with the dev-app by removing the "MaterialModules" anti-pattern. This will allow us to add lazy loading to the e2e app in a future PR.
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.