Skip to content

build: use ts-api-guardian from npm #15878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: use ts-api-guardian from npm #15878

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 23, 2019
@alan-agius4
Copy link
Contributor Author

Blocked by angular/angular#30051

@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review April 27, 2019 05:54
@alan-agius4
Copy link
Contributor Author

//cc @mmalerba & @devversion

@devversion devversion self-assigned this Apr 29, 2019
devversion
devversion approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 30, 2019
@mmalerba
Copy link
Contributor

This PR was included in #15909

@mmalerba mmalerba closed this Apr 30, 2019
@devversion
Copy link
Member

Oh right 😄 Interesting that it didn't show any conflicts/rebase message.

@alan-agius4 alan-agius4 deleted the build-use-ts-api-guardian-npm branch April 30, 2019 17:43
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alan-agius4 @mmalerba @devversion @jelbourn @googlebot