refactor: don't depend on @Inject for _MatMenuBase DI #15975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
In Ivy, undecorated base classes (like _MatMenuBase) don't have the same behavior as View Engine; specifically, inheriting the constructor from the base class will not work in the DI system. Even in View Engine this was often counter-intuitive - only constructors with DI decorators would be properly inherited in JIT. This commit updates _MatMenuBase to not rely on this implementation detail of Angular, and instead moves the injected constructor onto _MatMenu itself.
jelbourn
added
P1
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 8, 2019
With Ivy, directives or components no longer properly inherit a constructor from a parent base class which is undecorated. See more details here: FW-1238 In order to avoid dependency injection issues with Ivy, a new custom TSLint rule reports a failure when a directive/component uses dependency injection in a way that breaks with Ivy. Related to angular#15975
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 8, 2019
With Ivy, directives or components no longer properly inherit a constructor from a parent base class which is undecorated. See more details here: FW-1238 In order to avoid dependency injection issues with Ivy, a new custom TSLint rule reports a failure when a directive/component uses dependency injection in a way that breaks with Ivy. Related to angular#15975
|
The MDC based impl needs the same fix, as I'm a hitting a failure after rebasing ivy-2019. I'm putting the fix in in the ivy-2019 branch manually now, if it's possible to also get the change in here that would be awesome :) |
jelbourn
pushed a commit
that referenced
this pull request
May 10, 2019
With Ivy, directives or components no longer properly inherit a constructor from a parent base class which is undecorated. See more details here: FW-1238 In order to avoid dependency injection issues with Ivy, a new custom TSLint rule reports a failure when a directive/component uses dependency injection in a way that breaks with Ivy. Related to #15975
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
In Ivy, undecorated base classes (like _MatMenuBase) don't have the same behavior as View Engine; specifically, inheriting the constructor from the base class will not work in the DI system. Even in View Engine this was often counter-intuitive - only constructors with DI decorators would be properly inherited in JIT. This commit updates _MatMenuBase to not rely on this implementation detail of Angular, and instead moves the injected constructor onto _MatMenu itself.
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
With Ivy, directives or components no longer properly inherit a constructor from a parent base class which is undecorated. See more details here: FW-1238 In order to avoid dependency injection issues with Ivy, a new custom TSLint rule reports a failure when a directive/component uses dependency injection in a way that breaks with Ivy. Related to angular#15975
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ivy, undecorated base classes (like _MatMenuBase) don't have the same
behavior as View Engine; specifically, inheriting the constructor from the
base class will not work in the DI system. Even in View Engine this was
often counter-intuitive - only constructors with DI decorators would be
properly inherited in JIT.
This commit updates _MatMenuBase to not rely on this implementation detail
of Angular, and instead moves the injected constructor onto _MatMenu itself.
Fixes #15937