-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: add rule to warn for undecorated base classes #15976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add rule to warn for undecorated base classes #15976
Conversation
With Ivy, directives or components no longer properly inherit a constructor from a parent base class which is undecorated. See more details here: FW-1238 In order to avoid dependency injection issues with Ivy, a new custom TSLint rule reports a failure when a directive/component uses dependency injection in a way that breaks with Ivy. Related to angular#15975
f67f3fd
to
9aed09e
Compare
Address feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Needs #15975 to go in first |
@devversion does this need to be rebased to fix the lint error? |
@jelbourn Yes this needs a rebase. I can't do it right now, but merging this like that should technically work too. |
With Ivy, directives or components no longer properly inherit a constructor from a parent base class which is undecorated. See more details here: FW-1238 In order to avoid dependency injection issues with Ivy, a new custom TSLint rule reports a failure when a directive/component uses dependency injection in a way that breaks with Ivy. Related to angular#15975
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With Ivy, directives or components no longer properly inherit
a constructor from a parent base class which is undecorated.
See more details here: FW-1238
In order to avoid dependency injection issues with Ivy, a new
custom TSLint rule reports a failure when a directive/component
uses dependency injection in a way that breaks with Ivy.
Related to #15975