-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(tabs): no longer use OnPush #16529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/material/tabs/tab-group.ts
Outdated
@@ -84,7 +84,8 @@ const _MatTabGroupMixinBase: CanColorCtor & CanDisableRippleCtor & typeof MatTab | |||
templateUrl: 'tab-group.html', | |||
styleUrls: ['tab-group.css'], | |||
encapsulation: ViewEncapsulation.None, | |||
changeDetection: ChangeDetectionStrategy.OnPush, | |||
// tslint:disable-next-line:validate-decorators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a comment about why we're disabling it? Also do we need to do this on all components or just the one that's around the template content?
Finally, the setup between tabs and stepper is pretty similar so my guess is that we might have to do the same there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I suspect we'll be doing this for any component that consumes a template, in which case we would just disable the lint. I wanted to do that in a separate PR.
b07ae39
to
c1de930
Compare
This resolves an issue with ivy where the template content would be checked out of sync with the tab view. See angular#15440 for additional context.
f65ee5e
to
aa14cf1
Compare
aa14cf1
to
27395ae
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This resolves an issue with ivy where the template content would be
checked out of sync with the tab view. See #15440 for additional
context.