Skip to content

fix(tabs): no longer use OnPush #16529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Conversation

jelbourn
Copy link
Member

This resolves an issue with ivy where the template content would be
checked out of sync with the tab view. See #15440 for additional
context.

@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jul 15, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2019
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 15, 2019
@ngbot
Copy link

ngbot bot commented Jul 15, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: ivy_test" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending status "ci/circleci: bazel_build" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@@ -84,7 +84,8 @@ const _MatTabGroupMixinBase: CanColorCtor & CanDisableRippleCtor & typeof MatTab
templateUrl: 'tab-group.html',
styleUrls: ['tab-group.css'],
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush,
// tslint:disable-next-line:validate-decorators
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a comment about why we're disabling it? Also do we need to do this on all components or just the one that's around the template content?

Finally, the setup between tabs and stepper is pretty similar so my guess is that we might have to do the same there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suspect we'll be doing this for any component that consumes a template, in which case we would just disable the lint. I wanted to do that in a separate PR.

@mmalerba mmalerba added this to the 9.0.0 milestone Oct 2, 2019
This resolves an issue with ivy where the template content would be
checked out of sync with the tab view. See angular#15440 for additional
context.
@jelbourn jelbourn merged commit 35b3226 into angular:master Oct 11, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants