Skip to content

feat(cdk-experimental/clipboard): add better support for iOS devices, preliminary documentations #16830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

xkxx
Copy link
Collaborator

@xkxx xkxx commented Aug 20, 2019

Hello,

This PR builds up on #16704 and adds better support for iOS devices as well as some preliminary documentations for the clipboard.

Please take a look. Thanks!

xkxx

@xkxx xkxx requested a review from jelbourn as a code owner August 20, 2019 22:32
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 20, 2019
## The `Clipboard` service

The `Clipboard` service copies text to the
user's clipboard. It has two methods, `copy` and `beginCopy`. For cases where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For cases where you are copying a relatively small amount of text,"
->
"For relatively short text,"

Is there any quantitative guidance here? A certain number of characters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know of any - it very much depends on the user's computer specs. We could do some research about this and update the section before release.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 21, 2019
@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Aug 26, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 26, 2019
@jelbourn jelbourn merged commit eedf314 into angular:master Aug 27, 2019
mmalerba pushed a commit to mmalerba/components that referenced this pull request Aug 27, 2019
… preliminary documentations (angular#16830)

* Clipboard: add better support for iOS devices, preliminary documentations

* Clipboard: address review comments

* Clipboard: more documentation fixes
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants