Skip to content

build: remove rollup windows postinstall workaround #17669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ yarn_install(
"//:tools/bazel/flat_module_factory_resolution.patch",
"//:tools/bazel/manifest_externs_hermeticity.patch",
"//:tools/bazel/postinstall-patches.js",
"//:tools/bazel/rollup_windows_arguments.patch",
"//:tools/npm/check-npm.js",
],
package_json = "//:package.json",
Expand Down
9 changes: 0 additions & 9 deletions tools/bazel/postinstall-patches.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,6 @@ searchAndReplace(
`,
'node_modules/@angular/compiler-cli/src/ngtsc/entry_point/src/logic.js');

// Workaround for https://github.com/angular/angular/issues/32603.
try {
shelljs.cat(path.join(__dirname, './rollup_windows_arguments.patch')).exec('patch -p0');
} catch (_) {
// This is getting fixed in ng_rollup_bundle itself but due to the dependency sandwich
// between this repo and the material-unit-test job in the angular repo we need to add
// this try/catch here temporarily.
}

// Workaround for: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ?both. We only want to discard
// the metadata of files in the bazel managed node modules. That way we keep the default
// behavior of ngc-wrapped except for dependencies between sources of the library. This makes
Expand Down
63 changes: 0 additions & 63 deletions tools/bazel/rollup_windows_arguments.patch

This file was deleted.