Skip to content

Revert "Revert "build: fix missing amd module name for primary entry-point (#17757)"" #17775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

Revert "Revert "build: fix missing amd module name for primary entry-point (#17757)"" #17775

merged 1 commit into from
Nov 21, 2019

Conversation

mmalerba
Copy link
Contributor

Reverts #17772

This commit was not the cause of the breakage

@mmalerba mmalerba requested a review from devversion November 21, 2019 19:46
@mmalerba mmalerba requested a review from jelbourn as a code owner November 21, 2019 19:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 21, 2019
@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Nov 21, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 21, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Nov 21, 2019
@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 21, 2019
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 21, 2019
@mmalerba mmalerba merged commit 74dde10 into master Nov 21, 2019
@mmalerba mmalerba deleted the revert-17772-revert-material-module-name branch November 21, 2019 22:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @devversion @googlebot