fix(google-maps): internal events run inside NgZone #18034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
CaerusKaru
reviewed
Dec 27, 2019
crisbeto
force-pushed
the
google-maps-events-zone
branch
from
cd7251b to
89836cb
Compare
jelbourn
reviewed
Jan 14, 2020
crisbeto
force-pushed
the
google-maps-events-zone
branch
from
89836cb to
f60d5e6
Compare
|
Changed to make the |
jelbourn
added
pr: lgtm
action: merge
jelbourn
added
the
merge: caretaker note
|
Caretaker: cherry-pick this into |
The custom Google Maps event work by binding everything ahead of time and then dispatching the results to the various listeners, however the result of this is that they'll trigger change detection for events that the consumer hasn't subscribed to. These changes switch to initializing the Google Maps objects outside the `NgZone` and then only bringing the ones that the consumer has subscribed to back inside.
|
Rebased. |
crisbeto
force-pushed
the
google-maps-events-zone
branch
from
f60d5e6 to
629d095
Compare
Merged
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
The custom Google Maps event work by binding everything ahead of time and then dispatching the results to the various listeners, however the result of this is that they'll trigger change detection for events that the consumer hasn't subscribed to. These changes switch to initializing the Google Maps objects outside the `NgZone` and then only bringing the ones that the consumer has subscribed to back inside.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom Google Maps events work by binding everything ahead of time and then dispatching the results to the various listeners, however the result of this is that they'll trigger change detection for events that the consumer hasn't subscribed to. These changes switch to initializing the Google Maps objects outside the
NgZoneand then only bringing the ones that the consumer has subscribed to back inside.