Maps rectangle #18184
Maps rectangle #18184
Conversation
Add rectangle component to @angular/google-maps that allows rectangles to be overlayed over the Google map.
Add tests and demo for MapRectangle component.
Updates the public API with MapRectangle component.
googlebot
added
the
cla: yes
| const combinedOptionsChanges = this._combineOptions(); | ||
|
|
||
| combinedOptionsChanges.pipe(take(1)).subscribe(options => { | ||
| this._rectangle = new google.maps.Rectangle(options); |
There was a problem hiding this comment.
FYI there's an incoming change to initialize these objects outside the NgZone: #18034.
There was a problem hiding this comment.
Okay, this is going into the separate "google-maps-next" branch, so in a forthcoming change I will merge in the latest changes from master and update both this and the Polygon component.
| const combinedOptionsChanges = this._combineOptions(); | ||
|
|
||
| combinedOptionsChanges.pipe(take(1)).subscribe(options => { | ||
| this._rectangle = new google.maps.Rectangle(options); |
There was a problem hiding this comment.
Also this will throw during server-side rendering. See how it's handled in the other components.
There was a problem hiding this comment.
I see. Does fixing this rely on the NgZone change or should I fix this now?
There was a problem hiding this comment.
I think that it relies on the NgZone changes since they update the event manager to emit events in the Zone. If this is urgent we can merge it in and I'll do a follow up PR to apply the same fix to the rectangle.
There was a problem hiding this comment.
Okay, no rush on rectangle though. It's not going into any release yet, it's the separate "google-maps-next" branch.
Remove unnecessary listeners array.
jelbourn
added
pr: lgtm
action: merge
Add rectangle component to @angular/google-maps that allows rectangles to be overlayed over the Google map.
Add rectangle component to @angular/google-maps that allows rectangles to be overlayed over the Google map.
* feat(google-maps): Add MapPolygon component (#17936) Add MapPolygon component to Google Maps, allowing polygons to be added to a Google Map. * Maps rectangle (#18184) Add rectangle component to @angular/google-maps that allows rectangles to be overlayed over the Google map. * refactor(google-maps): Update new components with NgZone fix. Add NgZone fix to new components, map-rectangle and map-polygon. Co-authored-by: mbehrlich <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.