feat(google-maps): expose the underlying Google Maps objects. #18613
Conversation
googlebot
added
the
cla: yes
mbehrlich
added
feature
| * | ||
| * See developers.google.com/maps/documentation/javascript/reference/map#Map | ||
| */ | ||
| googleMap?: google.maps.Map; |
There was a problem hiding this comment.
Since the object is created asynchronously, maybe we should expose an Observable or a Promise instead?
There was a problem hiding this comment.
Possibly, I'm unsure if there's actually a case where the component is initialized but the google map object is unset outside of the server-side rendering case. I do not like the idea of an observable wrapped around a union of the map and undefined though. We could have the observable never emit if we are server-side rendering. Any thoughts, @jelbourn ?
There was a problem hiding this comment.
Can the map ever be uninitialized by ngOnInit? If so, what would happen? If there's no situation where the map can be undefined without throwing an error by the end of ngOnInit, I don't see the need to make it a promise/stream.
There was a problem hiding this comment.
The components were changed so that when they're loaded server side, the map is not initialized. However, in that case, the map is never initialized. To me, that seems like undefined would be more appropriate than an unemitted observable.
Expose the underlying Google Maps objects so they can be interacted with when it's necessary to do something unimplemented by angular/google-maps. As part of this change, update DefinitelyTyped so that we do not need a custom map object. Also standardize how underlying objects interact with the components and updates new components to work correctly when loading from the server.
Remove unused UpdatedGoogleMap type.
Remove references to UpdatedGoogleMap from tests.
Fix merge conflicts and update the Circle component with changes.
Update the public api with new changes.
Correct package.json file with correct version.
Fixes variable name that reverted due to merge.
…r#18613) Expose the underlying Google Maps objects so they can be interacted with when it's necessary to do something unimplemented by angular/google-maps. As part of this change, update DefinitelyTyped so that we do not need a custom map object. Also standardize how underlying objects interact with the components and updates new components to work correctly when loading from the server.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Expose the underlying Google Maps objects so they can be interacted with
when it's necessary to do something unimplemented by
angular/google-maps. As part of this change, update DefinitelyTyped so
that we do not need a custom map object. Also standardize how
underlying objects interact with the components and updates new
components to work correctly when loading from the server.