Skip to content

refactor(material-experimental/mdc-form-field): unset MDC custom baseline adjustment #18892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020
Merged

refactor(material-experimental/mdc-form-field): unset MDC custom baseline adjustment #18892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/material-experimental/mdc-form-field/_mdc-text-field-structure-overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,14 @@
.mat-mdc-form-field .mat-mdc-text-field-wrapper.mdc-text-field .mdc-notched-outline__notch {
padding-top: 0;
}

// Unset the baseline adjustment styles that are applied to the `.mdc-text-field` before
// pseudo element. We control the vertical alignment of form field controls using infix
// spacing since we support custom form-field controls. Those don't necessarily have an
// explicit height that matches with the Material Design specification. If the height isn't
// explicitly set to a specific value by MDC, the control will not align correctly vertically.
// e.g. No vertical spacing to the bottom-line if the control is too large.
.mat-mdc-text-field-wrapper::before {
content: none;
}
}