Skip to content

test(progress-bar): add basic e2e tests #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

crisbeto
Copy link
Member

Adds basic e2e tests that assert that the different progress bars are being rendered.

Referencing #559.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 16, 2016
@crisbeto
Copy link
Member Author

@kara can you take a look at the menu e2e change? I wasn't sure what the reasoning behind the bottom: 200px was, but it ended up causing the menu test triggers to overlap, which in turn caused tests to fail. This was because the list of links above was getting too tall.

Adds basic e2e tests that assert that the different progress bars are being rendered.

Referencing angular#559.
@kara
Copy link
Contributor

kara commented Nov 22, 2016

@crisbeto Ack, I can't remember. I assume it had to do with triggers being clickable at some point, but if the e2e tests pass now, it probably is no longer necessary. LGTM.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 28, 2016
@tinayuangao tinayuangao merged commit 7f37ec1 into angular:master Nov 28, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants