test(progress-circle): add basic e2e tests #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Note that the menu E2E tests will most likely fail now due to the amount of links pushing some of the buttons down. There is a fix for it at #1895. |
crisbeto
force-pushed
the
progress-circle-e2e
branch
from
4cb25d8 to
f663011
Compare
|
@crisbeto unblocked now? |
Adds basic assertions that the various progress circle variations have been rendered. Fixes angular#559.
crisbeto
force-pushed
the
progress-circle-e2e
branch
from
f663011 to
57abe8e
Compare
|
Yep, also rebased and resolved the conflicts. |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic assertions that the various progress circle variations have been rendered.
Fixes #559.