refactor(material-experimental/mdc-chips): implement trailing icon foundation #19318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
mmalerba
force-pushed
the
_cl_out_310167103
branch
from
170bece to
27edd2f
Compare
googlebot
added
the
cla: no
…undation Project import generated by Copybara. These changes are mostly based on @crisbeto's #18877 with some additional changes from @ProDee PiperOrigin-RevId: 310167103 Co-authored-by: crisbeto <[email protected]> Co-authored-by: prodee <[email protected]>
mmalerba
force-pushed
the
_cl_out_310167103
branch
from
27edd2f to
94ef838
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
mmalerba
changed the title
mmalerba
added
blocked
|
Marking as merge safe because this PR will be merged first in google3 |
mmalerba
removed
the
blocked
andrewseguin
added
lgtm
action: merge
mmalerba
force-pushed
the
_cl_out_310167103
branch
from
bf1d868 to
f45ceb4
Compare
mmalerba
added a commit
that referenced
this pull request
May 15, 2020
vanessanschmitt
added a commit
to vanessanschmitt/material2-vschmitt
that referenced
this pull request
Jun 1, 2020
Fixes an issue where pressing any non-arrow key while the chip remove icon is focused removes the chip. This should only happen for ENTER or SPACE. This issue was introduced when MDC refactored the chip foundation. The handleTrailingIconInteraction method, which used to call shouldHandleInteraction to detect if the keydown event was ENTER or SPACE, was replaced with handleTrailingActionInteraction, which handles all keydown events. This change was made in github.com/material-components/material-components-web/pull/5890, and MDC chips were migrated in github.com/angular/pull/19318.
vanessanschmitt
added a commit
to vanessanschmitt/material2-vschmitt
that referenced
this pull request
Jun 1, 2020
Fixes an issue where pressing any non-arrow key while the chip remove icon is focused removes the chip. This should only happen for ENTER or SPACE. This issue was introduced when MDC refactored the chip foundation. The handleTrailingIconInteraction method, which used to call shouldHandleInteraction to detect if the keydown event was ENTER or SPACE, was replaced with handleTrailingActionInteraction, which handles all keydown events. This change was made in material-components/material-components-web/pull/5890, and MDC chips were migrated in angular/pull/19318.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project import generated by Copybara.
These changes are mostly based on @crisbeto's #18877 with some
additional changes from @ProDee