fix(tree): allow use of FlatTreeControl's trackBy function in MatTreeFlatDataSource and MatTreeFlattener #19600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce and MatTreeFlattener
googlebot
added
the
cla: yes
crisbeto
added
merge: fix commit message
|
Commit message fixup: should start with |
tjaneczko
changed the title
|
Thanks for the review! I updated the title, do I also need to update the messages for individual commits within this PR? Do I need to merge these commits together? |
|
I think it should be fine since the caretaker squashes the commits when they merge something in. |
andrewseguin
approved these changes
Jun 16, 2020
jelbourn
added
G
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to track tree-node expansion via a
trackByfunction was added to FlatTreeControl in #18708. It's currently not feasible to use this in combination with MatTreeFlattener or MatTreeFlatDataSource, as they don't support the additional type variable in FlatTreeControl. This PR adds the additional type variable to these classes in a similar manner to how they were added to FlatTreeControl.