test(tabs): add performance tests for mat-tabs #19752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Jun 25, 2020
| isLargeTabGroupVisible = false; | ||
|
|
||
| showSmallTabGroup() { this.isSmallTabGroupVisible = true; } | ||
| showLargeTabGroup() { this.isLargeTabGroupVisible = true; } |
There was a problem hiding this comment.
Since the two properties are public, couldn't you change them directly from the view without going through a method?
There was a problem hiding this comment.
Yes, this is just my preferred way to do this
wagnermaciel
force-pushed
the
tabs-benchmark
branch
from
be9d528 to
596071a
Compare
|
This performance test cannot be merged in until PR #38026 is completed. I will revisit this PR once it is merged. |
wagnermaciel
force-pushed
the
tabs-benchmark
branch
from
b4c908c to
550478d
Compare
wagnermaciel
added
action: merge
devversion
reviewed
Aug 3, 2020
wagnermaciel
force-pushed
the
tabs-benchmark
branch
from
550478d to
b25b412
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Aug 12, 2020
* test(tabs): add performance tests for mat-tabs * fixup! test(tabs): add performance tests for mat-tabs * fixup! test(tabs): add performance tests for mat-tabs * fixup! test(tabs): add performance tests for mat-tabs * fixup! test(tabs): add performance tests for mat-tabs (cherry picked from commit 094a49c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview