Skip to content

Fix dev-infra zone.js substitution #38026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix dev-infra zone.js substitution #38026

wants to merge 2 commits into from

Conversation

wagnermaciel
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@wagnermaciel wagnermaciel force-pushed the fix-zone-js-substitution branch 2 times, most recently from 10d8a79 to fd576a1 Compare July 13, 2020 17:55
@wagnermaciel wagnermaciel marked this pull request as ready for review July 13, 2020 18:31
@pullapprove pullapprove bot requested a review from devversion July 13, 2020 18:31
devversion
devversion approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We probably need to update the target path when there is as new zone.js release. We should then import from zone.js/bundles/zone.umd.js I guess.

@devversion devversion added area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 13, 2020
@ngbot ngbot bot modified the milestone: needsTriage Jul 13, 2020
@wagnermaciel wagnermaciel removed the action: merge The PR is ready for merge by the caretaker label Jul 13, 2020
@wagnermaciel
Copy link
Contributor Author

I'm gonna re-test this tomorrow. I am afraid I might have tested against a local / cached version of dev-infra that I modified manually instead of the one build off of this branch. For some reason I need to run yarn bazel clean --expunge for each new build I want to test

@wagnermaciel
fix(dev-infra): fix broken zone.js substitution for dev-infra:npm_pac…
b793077 
…kage

* fix substitution that was broken by PR angular#36540 to match
  the new import path
@wagnermaciel
fix(dev-infra): add missing BUILD file to dev-infra/bazel:files
e3be45d 
* Without this BUILD file we were seeing errors about the reference to
  expand_template.bzl in ng_rollup_bundle.bzl because dev-infra/bazel
  was not considered a package.
@wagnermaciel wagnermaciel force-pushed the fix-zone-js-substitution branch from fd576a1 to e3be45d Compare July 14, 2020 20:08
@wagnermaciel wagnermaciel requested a review from devversion July 14, 2020 20:13
devversion
devversion approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +💯

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2020
@wagnermaciel wagnermaciel mentioned this pull request Jul 14, 2020
Merged
AndrewKushnir pushed a commit that referenced this pull request Jul 15, 2020
@wagnermaciel @AndrewKushnir
fix(dev-infra): fix broken zone.js substitution for dev-infra:npm_pac…
0320096 
…kage (#38026)

* fix substitution that was broken by PR #36540 to match
  the new import path

PR Close #38026
AndrewKushnir pushed a commit that referenced this pull request Jul 15, 2020
@wagnermaciel @AndrewKushnir
fix(dev-infra): add missing BUILD file to dev-infra/bazel:files (#38026)
f2ee468 
* Without this BUILD file we were seeing errors about the reference to
  expand_template.bzl in ng_rollup_bundle.bzl because dev-infra/bazel
  was not considered a package.

PR Close #38026
AndrewKushnir pushed a commit that referenced this pull request Jul 15, 2020
@wagnermaciel @AndrewKushnir
fix(dev-infra): add missing BUILD file to dev-infra/bazel:files (#38026)
09eee5b 
* Without this BUILD file we were seeing errors about the reference to
  expand_template.bzl in ng_rollup_bundle.bzl because dev-infra/bazel
  was not considered a package.

PR Close #38026
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 15, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@wagnermaciel @profanis
fix(dev-infra): fix broken zone.js substitution for dev-infra:npm_pac…
201347d 
…kage (angular#38026)

* fix substitution that was broken by PR angular#36540 to match
  the new import path

PR Close angular#38026
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@wagnermaciel @profanis
fix(dev-infra): add missing BUILD file to dev-infra/bazel:files (angu…
e4ab5d2 
…lar#38026)

* Without this BUILD file we were seeing errors about the reference to
  expand_template.bzl in ng_rollup_bundle.bzl because dev-infra/bazel
  was not considered a package.

PR Close angular#38026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.
3 participants
@wagnermaciel @devversion @googlebot