refactor(material/datepicker): consistently import MatCommonModule everywhere #19861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
common-module-imports
branch
from
00289ea to
0154fad
Compare
crisbeto
changed the title
…erywhere The `MatCommonModule` is inteded to be imported in all Material modules since it includes some sanity checks and RTL handling, however we weren't importing it consistently. These changes add it to all the places where it was missing.
crisbeto
force-pushed
the
common-module-imports
branch
from
0154fad to
000559d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MatCommonModuleis inteded to be imported in all Material modules since it includes some sanity checks and RTL handling, however we weren't importing it consistently. These changes add it to all the places where it was missing.