ci: update remote browsers we test against #19961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Updates our remote browsers so that we test against the latest Egde version, the latest iOS and macOS Safari versions.
devversion
force-pushed
the
build/update-remote-browsers
branch
from
e000b3e to
9a56b0d
Compare
…ctly for videos, audio and object elements The interactivity checker has been built a while ago when supported browsers behaved differently for their `tabbable` state. We now updated our browsers to more recent versions, and need to adjust the interactivity checker so that it reflects the latest patterns in supported browsers. Here is a note summary of behavior noticed for `video` and `audio` elements in various supported browsers: https://hackmd.io/@devversion/rkxzcgsJD Another change was for `object` elements. In previous BLINK / Webkit browsers, such elements, or its children were never tabbable. This is incorrect for the currently supported browsers as children inside `object` elements can certainly be tabbable. On the other hand though, object elements itself can be tabbable depending on configuration we cannot reliably detect. For improved accessibility, we never consider object elements itself as tabbable (similar to iframes)
* Updates the MDC-based slider tests to work in Safari v13.1 * Updates the MDC-based slider tests so that the measurements are guaranteed to be based on a 100px wide slider (seems like this is not always the case sometimes; resulting in flakiness).
devversion
added
P2
|
Note that there is a second PR for updating Firefox. That one is managed by Bazel so it's more complicated. I'm working on a version of Firefox we can control in: angular/angular#38029 |
This was referenced Jul 15, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.