build: update firefox to latest version #20014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
merge safe
P2
Updates our Firefox version that is used for Bazel unit tests to v78.0. Previously we were using v68. To update the Firefox version, we had to set up a custom Browser target with repositories as the version for Firefox is usually hard-coded in `rules_webtesting` and we cannot control that. See related change in the dev-infra package: angular/angular#38029.
…ations A small set of popover-edit tests relies on the bounding client rect. Assertions that the panel stretches over the first and last cell are correct but require an exact equality. This is not reliable as in some situations, browsers handle subpixels differently, resulting in small deviations in the bounding client rect positions. These differences are only noticeable less significant decimal places, but the overall assertion matches full pixels. This is sufficient for these tests so we just round all measurements/comparisons to full pixels.
devversion
force-pushed
the
build/update-firefox-test-version
branch
7 times, most recently
from
5bd2f61 to
8922d45
Compare
devversion
requested review from
andrewseguin,
mmalerba and
a team
as code owners
crisbeto
reviewed
Jul 17, 2020
| @@ -564,6 +564,10 @@ matPopoverEditTabOut`, fakeAsync(() => { | |||
| }); | |||
|
|
|||
| describe('edit lens', () => { | |||
| function expectPixelsToEqual(actual: number, expected: number) { | |||
| expect(Math.round(actual)).toBe(Math.round(expected)); | |||
There was a problem hiding this comment.
Usually I do Math.floor or Math.ceil for assertions like this, because with round you could get a mismatch for 1.4 vs 1.6.
There was a problem hiding this comment.
Yeah, that is tricky. I checked and saw lots of Math.round assertions in our code base. We don't seem to do it consistently. One benefit of round will be that we potentially spot one-off issues easier (as the browser potentially will round the pixels depending). I'll switch it to Math.floor.
The datepicker position tests seem to be thrown off in Firefox v78 where inputs have an uneven width (resulting in subpixel rendering that is not predictable and stable enough for our test assertions)
devversion
force-pushed
the
build/update-firefox-test-version
branch
from
8922d45 to
2753c01
Compare
devversion
added
the
merge: preserve commits
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates our Firefox version that is used for Bazel unit tests to v78.0.
Previously we were using v68.
To update the Firefox version, we had to set up a custom Browser target
with repositories as the version for Firefox is usually hard-coded in
rules_webtestingand we cannot control that.See related change in the dev-infra package: angular/angular#38029.
This is an addition to: #19961