build: fix chips drag-drop example not working and improve example-module generation #20003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P2
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/fix-examples-chips
branch
2 times, most recently
from
dcfd965 to
cd05f95
Compare
…dule generation Loading the chips-drag-drop example in the docs site is currently not possible, as the example files fail to load. This is because the example id does not match up with the directory that the example is stored within. This highlights an issue as the docs site assumes a certain folder structure. This is not ideal and an implementation detail specific to the Angular Components repository. The docs site should not need to make any assumptions about where code lives, but instead should just retrieve this information through the example information. That way we are free to change layout/file conventions in the components repository without having to worry about it breaking the docs site. This is implemented as part of this commit. Also a few sanity checks that enforce consistency (for improved code health) have been added. The new concept for examples also allows us to remove empty CSS files for examples without CSS.
We now can have examples without CSS files. This was previously not possible and the docs site just failed loading as it assumed a CSS file per example. We remove those empty stylesheets as they are superflous to examples and rather can confuse/distract the examples in the docs.
devversion
force-pushed
the
build/fix-examples-chips
branch
from
cd05f95 to
e506b1b
Compare
devversion
requested review from
andrewseguin,
mmalerba and
a team
as code owners
andrewseguin
added
target: minor
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
…dule generation (angular#20003) * build: fix chips drag-drop example not working and improve example-module generation Loading the chips-drag-drop example in the docs site is currently not possible, as the example files fail to load. This is because the example id does not match up with the directory that the example is stored within. This highlights an issue as the docs site assumes a certain folder structure. This is not ideal and an implementation detail specific to the Angular Components repository. The docs site should not need to make any assumptions about where code lives, but instead should just retrieve this information through the example information. That way we are free to change layout/file conventions in the components repository without having to worry about it breaking the docs site. This is implemented as part of this commit. Also a few sanity checks that enforce consistency (for improved code health) have been added. The new concept for examples also allows us to remove empty CSS files for examples without CSS. * chore: remove empty CSS files from examples We now can have examples without CSS files. This was previously not possible and the docs site just failed loading as it assumed a CSS file per example. We remove those empty stylesheets as they are superflous to examples and rather can confuse/distract the examples in the docs.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the chips-drag-drop example in the docs site is currently not
possible, as the example files fail to load. This is because the example
id does not match up with the directory that the example is stored within.
This highlights an issue as the docs site assumes a certain folder
structure. This is not ideal and an implementation detail specific to
the Angular Components repository. The docs site should not need to
make any assumptions about where code lives, but instead should just
retrieve this information through the example information. That way we
are free to change layout/file conventions in the components repository
without having to worry about it breaking the docs site.
This is implemented as part of this commit. Also a few sanity checks
that enforce consistency (for improved code health) have been added. The
new concept for examples also allows us to remove empty CSS files for
examples without CSS.