This repository was archived by the owner on Dec 18, 2024. It is now read-only.
refactor: prepare for docs-content changes in v10.1 #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently refactored how our docs-content example module is composed. We did this because the docs app assumes path in the docs-content package that are not necessarily always correct. i.e. breaking the chips drag and drop example. Additionally the docs-content example module is now more self-contained so that assumptions about files inside of an example are not required anymore. i.e. examples can now _not_ have CSS or HTML files. Previously we always had to display an empty CSS/HTML file (which is confusing).
andrewseguin
approved these changes
Jul 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently refactored how our docs-content example module is composed.
We did this because the docs app assumes path in the docs-content
package that are not necessarily always correct. i.e. breaking the chips
drag and drop example.
Additionally the docs-content example module is now more self-contained
so that assumptions about files inside of an example are not required
anymore. i.e. examples can now not have CSS or HTML files. Previously
we always had to display an empty CSS/HTML file (which is confusing).
See: angular/components#20003