-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(table): expand cell harness api #21162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): expand cell harness api #21162
Conversation
Besides text, table cells can contain other components. Extending from ContentContainerComponentHarness exposes more apis to query for children in the table cell. Closes #21157
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are fine, but for some reason the CI didn't run on your PR. If it did, I'm pretty sure that it would've failed, because the API goldens need to be updated too. You can update them using yarn approve-api table/testing
.
@josephperrott do you know why the CI didn't run here?
} from '@angular/cdk/testing'; | ||
import {CellHarnessFilters} from './table-harness-filters'; | ||
|
||
/** Harness for interacting with a standard Angular Material table cell. */ | ||
export class MatCellHarness extends ComponentHarness { | ||
export class MatCellHarness extends ContentContainerComponentHarness { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same changes need to be made in the cell-harness
under experimental
.
@crisbeto Thanks for your feedback. I resolved the comments with a new commit. |
It doesn't look like the CI checks ran this time around either. |
@crisbeto Is there anything I can do about that? |
I've heard that this can happen if somehow Circle CI is enabled on your fork so that might be something worth checking. |
I looked into it and am unsure of why CircleCI did not run as expected in this case. I have manually triggered our CI run. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Besides text, table cells can contain other components.
Extending from ContentContainerComponentHarness
exposes more apis to query for children in the table cell.
Closes #21157