-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs(material/checkbox): updated docs for default option value for ch… #21226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eckbox updates the documentation of customizing the default option of the checkbox. the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…eckbox updates the documentation of customizing the default option of the checkbox. the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. The changes look good, but we still have a couple other places where MAT_CHECKBOX_CLICK_ACTION
is referenced in the docs. Can we take the chance to update them as well?
Here's where it needs to be updated:
src\material\checkbox\testing\checkbox-harness.ts
src\material-experimental\mdc-checkbox\testing\checkbox-harness.ts
yes. sure...will make changes... |
I find
shall I make changes there as well ? |
Let's leave those in since they're unit tests. We can clean them up once the deprecated symbol is removed completely. |
ok fine...will leave those.. |
…PTIONS for customizing checkbox behaviour updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…eckbox updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…eckbox updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…PTIONS for customizing checkbox behaviour updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…PTIONS for customizing checkbox behaviour updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…PTIONS for customizing checkbox behaviour updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
… value for checkbox updates the documentation of customizing the default option of the checkbox. the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
…PTIONS for customizing checkbox behaviour updates the comments in testing files in checkbox with MAT_CHECKBOX_DEFAULT_OPTIONS the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10 fixes #21025
Hi...I made the suggested changes. but im not sure why the circleci build fails. Im trying to solve this, but finding it bit difficult. this is my first PR. if you have time can you please help me solve this. else I shall open a new PR with these changes. |
I will close this pull request and open a new one :) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…eckbox
updates the documentation of customizing the default option of the checkbox.
the default option value to provide for checkbox is MAT_CHECKBOX_DEFAULT_OPTIONS for version>=10
fixes #21025