Skip to content

build: update size check goldens #21232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

build: update size check goldens #21232

merged 1 commit into from
Dec 8, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 6, 2020

The size check goldens have fallen behind since we don't run them on the CI. These changes update them to the latest values.

@crisbeto
build: update size check goldens
add771c 
The size check goldens have fallen behind since we don't run them on the CI.
These changes update them to the latest values.
@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Dec 6, 2020
@crisbeto crisbeto requested a review from a team as a code owner December 6, 2020 17:25
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2020
josephperrott
josephperrott approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel merged commit cf0efb5 into angular:master Dec 8, 2020
wagnermaciel pushed a commit that referenced this pull request Dec 8, 2020
@crisbeto @wagnermaciel
build: update size check goldens (#21232)
73a8402 
The size check goldens have fallen behind since we don't run them on the CI.
These changes update them to the latest values.

(cherry picked from commit cf0efb5)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @josephperrott @wagnermaciel