docs: fix SVG icon example on Stackblitz #21429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SVG icon examples 404s when opened on Stackblitz due to an old issue with static assets. These changes switch to using an icon literal so that we don't have to fetch the icon. Fixes angular#16484.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
annieyw
pushed a commit
that referenced
this pull request
Jan 7, 2021
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
The SVG icon examples 404s when opened on Stackblitz due to an old issue with static assets. These changes switch to using an icon literal so that we don't have to fetch the icon. Fixes angular#16484.
|
@crisbeto Hey there, I talked to Eric from StackBlitz about this problem and he solved it about 3 weeks ago, almost at the same time you made this change. StackBlitz also allows linking to other assets like images now (which didn't work before) and can even preview them in the browser. See here: https://stackblitz.com/edit/angular-ahvbuu?file=src/app/icon-svg-example.ts So you may revert this commit :) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SVG icon examples 404s when opened on Stackblitz due to an old issue with static assets. These changes switch to using an icon literal so that we don't have to fetch the icon.
Fixes #16484.