Update rules nodejs #21928
Merged
Update rules nodejs #21928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
requested review from
devversion,
jelbourn and
a team
as code owners
google-cla
bot
added
the
cla: yes
jelbourn
reviewed
Feb 17, 2021
crisbeto
approved these changes
Feb 17, 2021
josephperrott
force-pushed
the
update-rules-nodejs
branch
from
5c84d21 to
fee339e
Compare
josephperrott
force-pushed
the
update-rules-nodejs
branch
2 times, most recently
from
b64d8f4 to
7d0b9eb
Compare
josephperrott
added
target: patch
jelbourn
approved these changes
Feb 17, 2021
| @@ -3,12 +3,12 @@ | |||
| * want to launch any browser and just enable manual browser debugging. | |||
| */ | |||
|
|
|||
| const bazelKarma = require('@bazel/karma'); | |||
| const bazelKarma = require('@bazel/concatjs'); | |||
There was a problem hiding this comment.
I find it really strange that they changed these rules to live under a package named for the bundler 😕
There was a problem hiding this comment.
Yeah, my guess is that its about consolidation overall: https://github.com/bazelbuild/rules_nodejs/wiki#introducing-bazelconcatjs
josephperrott
added
target: patch
crisbeto
approved these changes
Feb 18, 2021
josephperrott
force-pushed
the
update-rules-nodejs
branch
2 times, most recently
from
e2faea4 to
5addaed
Compare
josephperrott
force-pushed
the
update-rules-nodejs
branch
from
4623415 to
54834e2
Compare
Update to use [email protected] and update correseponding build rule usages and references
Loading the dev-infra rules via the @npm// workspace as the private @npm_dev_infra_private repo is no longer published.
… type Update JSON.parse usages to be better typed rather than resulting in an any type.
… as a type Update JSON.parse usages to be better typed rather than resulting in an any type.
josephperrott
force-pushed
the
update-rules-nodejs
branch
from
54834e2 to
6676d3e
Compare
andrewseguin
added
target: minor
Splaktar
reviewed
Mar 11, 2021
| @@ -0,0 +1 @@ | |||
| 12.14.1 | |||
There was a problem hiding this comment.
Is there any reason this can't just be 12? As is, it won't let me commit when I'm using NodeJS 12.21.0.
There was a problem hiding this comment.
The intention is that by using the exact same version here and on CI, there are not any unexpected differences between our usages.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.