Skip to content

Revert "fix(material-experimental/mdc-typography): strip typography properties" #21961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andrewseguin
Copy link
Contributor

Reverts #21878

Breaks some builds in google3

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 19, 2021
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Feb 19, 2021
@@ -112,19 +113,9 @@ $mat-typography-2018-level-mappings: (
letter-spacing: mat-letter-spacing($mat-config, $mat-level),
font-family: mat-font-family($mat-config, $mat-level),
// Angular Material doesn't use text-transform, so disable it.
text-transform: null,
text-transform: none,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like switching this back to none is all we need to fix it

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 22, 2021
@josephperrott josephperrott deleted the revert-21878-mdc-button-lh branch June 29, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants