Skip to content

fix(material-experimental/mdc-select): fix floating label behavior #22134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix(material-experimental/mdc-select): fix floating label behavior #22134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/material-experimental/mdc-select/select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class MatSelect extends _MatSelectBase<MatSelectChange> implements OnInit
get shouldLabelFloat(): boolean {
// Since the panel doesn't overlap the trigger, we
// want the label to only float when there's a value.
return !this.empty;
return this.panelOpen || !this.empty;
}

ngOnInit() {
Expand Down Expand Up @@ -147,11 +147,12 @@ export class MatSelect extends _MatSelectBase<MatSelectChange> implements OnInit
open() {
this._overlayWidth = this._getOverlayWidth();
super.open();
// Required for the MDC form field to pick up when the overlay has been opened.
this.stateChanges.next();
}

close() {
super.close();

// Required for the MDC form field to pick up when the overlay has been closed.
this.stateChanges.next();
}
Expand Down