docs(cdk/coercion): expand overview #22791
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
|
||
| ### Example | ||
|
|
||
| ```ts |
There was a problem hiding this comment.
Should we make this a full example? It's pretty extensive for a code block
There was a problem hiding this comment.
My reasoning for keeping it inline is that the example won't be particularly visual since the coercion only affects the public API of the component.
Companion PR to angular/material.angular.io#994. Expands the overview of the coercion package so that we have more than one sentence to show.
| // It also allows for a string to be passed like `<my-button disabled="true"></my-button>`. | ||
| @Input() | ||
| get disabled() { return this._disabled; } | ||
| set disabled(value: any) { |
There was a problem hiding this comment.
Sorry to ask, but is any correct here (and in the other example)? I ask therefore, because as it is a bad practice, IMHO it shouldn't be in official docs as this can influence bad habits for other devs. Note that a simple boolean/number would solve it (as you already does in majority of your components).
Companion PR to angular/material.angular.io#994. Expands the overview of the coercion package so that we have more than one sentence to show. (cherry picked from commit 0b04570)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Companion PR to angular/material.angular.io#994. Expands the overview of the coercion package so that we have more than one sentence to show.