build: use specific MDC version #22880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
Please rebase |
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing angular#22504 yesterday, because it ended up installing a version that was too old. These changes lock us to a specific version.
crisbeto
force-pushed
the
specific-mdc-version
branch
from
1b7926e to
1e9d6ea
Compare
|
Rebased. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our MDC version requirement currently uses a caret with the intention of allowing any version after the specified canary. This isn't actually how npm works and it can end up installing an earlier version. The version isn't technically valid semver, causing the package manager to sort the versions alphabetically and to pick the last one. This behavior threw me off when rebasing #22504 yesterday, because it ended up installing a version that was too old.
These changes lock us to a specific version.