docs(icon): add overview file #2306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Dec 21, 2016
| # md-icon | ||
|
|
||
| `md-icon` is a component that displays an icon, which can be a font glyph or an SVG image. | ||
|
|
There was a problem hiding this comment.
How about
`md-icon` makes it easier to use _vector-based_ icons in your app.
This directive supports both icon fonts and SVG icons, but not bitmap-based formats (png, jpg, etc.).
|
|
||
| Note that all SVG icons are fetched via XmlHttpRequest, and due to the same-origin policy their URLs | ||
| must be on the same domain as the containing page, or their servers must be configured to allow | ||
| cross-domain access. |
There was a problem hiding this comment.
We need to note in here that, to guard against XSS, any URLs given to the MdIconRegistry must be marked as trusted resource URLs by using Angular's DomSantizer service.
|
Done |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.