Skip to content

build: update shared dev-infra package #23427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

devversion
Copy link
Member

See individual commits.

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Aug 23, 2021
@devversion devversion requested a review from a team as a code owner August 23, 2021 10:35
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2021
@devversion devversion added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Aug 23, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2021
@amysorto amysorto added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 23, 2021
Updates the shared dev-infra package to take advanatge
of recent improvements for the release tool.

This also fixes the issue where the merge tooling requires
the `breaking change` label, while there also is the
`state: breaking change` label. The ng-dev tool no longer
accepts custom configuration of that label.

Also the merge configuration no longer accepts custom labels,
in order to achieve consistent labeling as specified in the
Angular versioning/branching/labeling spec.
Updates the Github actions to latest revisions. The github
actions now correctly deal with `state: breaking change`
label.
Checks the `.ng-dev` tool configuration in CI, compared
to doing it locally when the caretaker intends to perform
a merge and then realizes the config is broken.
@devversion devversion force-pushed the build/update-dev-infra-private branch from 92e8dd3 to 1a3ea7b Compare August 25, 2021 16:56
@amysorto amysorto merged commit 5ba40c1 into angular:master Aug 25, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: preserve commits When the PR is merged, a rebase and merge should be performed target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants