build: fix error when dev app is deployed #23864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `index.html` of the dev app assumes that the `DEV_APP_VARIABLES` global variable will always be present, but that's not the case when it is deployed. This causes an error which prevents the Google Maps script from loading. These changes add a null check, as well as some docs about the `variables.json`.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
devversion
approved these changes
Oct 31, 2021
crisbeto
added
action: merge
jelbourn
added
target: minor
jelbourn
pushed a commit
that referenced
this pull request
Nov 2, 2021
The `index.html` of the dev app assumes that the `DEV_APP_VARIABLES` global variable will always be present, but that's not the case when it is deployed. This causes an error which prevents the Google Maps script from loading. These changes add a null check, as well as some docs about the `variables.json`. (cherry picked from commit 4579377)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
index.htmlof the dev app assumes that theDEV_APP_VARIABLESglobal variable will always be present, but that's not the case when it is deployed. This causes an error which prevents the Google Maps script from loading.These changes add a null check, as well as some docs about the
variables.json.