Skip to content

build: fix error when dev app is deployed #23864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

build: fix error when dev app is deployed #23864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions DEV_ENVIRONMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Developer guide: getting your environment set up

1. Make sure you have both `node` and `yarn` installed.
We recommend using `nvm` to manage your node versions.
2. angular/components uses Bazel which requires certain Bash and UNIX tools.
Expand All @@ -19,7 +18,6 @@ To bring up a local server, run `yarn dev-app`. This will automatically watch fo
and rebuild. The browser should refresh automatically when changes are made.

### Running tests

To run unit tests, run `yarn test <target>`. The `target` can be either a short name (e.g. `yarn test button`) or an explicit path `yarn test src/cdk/stepper`.
To run the e2e tests, run `yarn e2e`.
To run lint, run `yarn lint`.
Expand Down Expand Up @@ -67,7 +65,6 @@ at the file under `tools/public_api_guard/<target>.d.ts`.


### Disabling Git hooks

If your development workflow does not intend the commit message validation to run automatically
when commits are being created, or if you do not want to run the formatter upon `git commit`, you
can disable any installed Git hooks by setting `HUSKY=0` in your shell environment. e.g.
Expand All @@ -78,4 +75,11 @@ export HUSKY=0

# .bashrc
export HUSKY=0
```
```

### Injecting variables into the dev app
Variables can be injected into the dev app by creating the `src/dev-app/variables.json` file.
They'll be made available under the `window.DEV_APP_VARIABLES` object. The file isn't checked into
Git and it can be used to pass private configuration like API keys. Variables currently being used:

* `GOOGLE_MAPS_KEY` - Optional key for the Google Maps API.
5 changes: 3 additions & 2 deletions src/dev-app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@
<script src="https://www.youtube.com/iframe_api"></script>
<script src="https://unpkg.com/@googlemaps/markerclustererplus/dist/index.min.js"></script>
<script>
(function loadGoogleMaps(key) {
(function loadGoogleMaps(variables) {
var key = variables ? variables.GOOGLE_MAPS_KEY : null;
var script = document.createElement('script');
script.src = 'https://maps.googleapis.com/maps/api/js?libraries=visualization' +
(key ? '&key=' + key : '');
document.body.appendChild(script);
})(window.DEV_APP_VARIABLES.GOOGLE_MAPS_KEY);
})(window.DEV_APP_VARIABLES);
</script>
<script src="bundles/dev-app/main.js" type="module"></script>
</body>
Expand Down