build: simplify karma configuration #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* No longer use ts-node to build the Karma configuration (just to be able to import the browser-providers) * Transformed the browser-providers into a JS file (with only the most necessary exports) * Separates the list of possible external browsers into an extra file (as in Material 1) This change just removes unnecessary bloat from our build process and also makes running karma a bit faster, because we don't need to build TS on the fly. Also it just makes the `browser-providers`, `karma.conf.js` and `remote_browsers` very clear.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 26, 2017
| 'Android5': { unitTest: {target: 'SL', required: false }}, | ||
| 'Safari7': { unitTest: {target: null, required: false }}, | ||
| 'Safari8': { unitTest: {target: 'BS', required: false }}, | ||
| 'Safari9': { unitTest: {target: 'BS', required: false }}, |
There was a problem hiding this comment.
Idle thought: looks like Browserstack still doesn't support Safari 10, but SauceLabs does. I wonder if we should try adding that (in a follow-up PR)
There was a problem hiding this comment.
Good idea. I will take a look at this once this PR is merged.
jelbourn
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jan 31, 2017
* This adds Safari v10 (from Saucelabs) to the browser-providers and marks it as an optional run in the CI. As requested in angular#2823
tinayuangao
pushed a commit
that referenced
this pull request
Feb 6, 2017
* This adds Safari v10 (from Saucelabs) to the browser-providers and marks it as an optional run in the CI. As requested in #2823
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just removes unnecessary bloat from our build process and also makes running karma a bit faster, because we don't need to build TS on the fly.
Also it just makes the
browser-providers,karma.conf.jsandremote_browsersvery clear.@jelbourn I noticed this while trying to integrate coverage. And I also planned to remove unnecessary bloat of our build process (right now it's too confusing & big)