Skip to content

chore: add safari10 to browser-providers #2873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Jan 31, 2017

Note: Optional Unit tests are temporary disabled since too many Saucelabs / Browserstack instances will cause CI flakiness.

* This adds Safari v10 (from Saucelabs) to the browser-providers and marks it as an optional run in the CI.

As requested in angular#2823
@devversion devversion requested a review from kara January 31, 2017 18:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 31, 2017
@devversion devversion requested review from mmalerba and removed request for kara February 5, 2017 11:36
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Feb 6, 2017
@tinayuangao tinayuangao merged commit e5ca565 into angular:master Feb 6, 2017
@devversion devversion deleted the chore/add-safari-10 branch February 6, 2017 20:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants