feat(table): add disconnect to data source #5382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 27, 2017
| @@ -14,4 +14,5 @@ export interface CollectionViewer { | |||
|
|
|||
| export abstract class DataSource<T> { | |||
| abstract connect(collectionViewer: CollectionViewer): Observable<T[]>; | |||
| disconnect() {} | |||
There was a problem hiding this comment.
Pass the collectionViewer to the data source?
There was a problem hiding this comment.
Makes sense to me, but it does require that all data sources need to implement it now. At least a no-op
There was a problem hiding this comment.
You can also mark disconnect as optional.
jelbourn
added
pr: lgtm
action: merge
|
Please fix the test |
andrewseguin
force-pushed
the
table-disconnect
branch
from
6031ef5 to
a3c9d96
Compare
|
@andrewseguin Please rebase again. Thanks |
andrewseguin
force-pushed
the
table-disconnect
branch
from
a3c9d96 to
dc9fe87
Compare
|
Rebased |
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* feat(data-table): add disconnect to data source * testing * add collectionviewer to disconnect
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnects the data source when it is no longer used, either by the table being destroyed or another data source taking its place