build: enforce consistent spacing in curly braces #6630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amcdnl,
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
devversion
approved these changes
Aug 24, 2017
jelbourn
added
pr: lgtm
action: merge
Adds a rule to enforce that we have consistent spacing inside curly braces and fixes any violations. Relates to angular#6615 (comment).
crisbeto
force-pushed
the
curly-braces-spaces
branch
from
5bc32f5 to
370ab93
Compare
jelbourn
added
pr: needs rebase
and removed
action: merge
|
This needs rebase, but hold off because I'm going to try to merge some other PRs first |
|
Closing for now. We can revisit once the PR queue is smaller. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rule to enforce that we have consistent spacing inside curly braces and fixes any violations.
Relates to #6615 (comment).