Skip to content

fix(sidenav-fab-example):removed overflow:auto; since there is no need for it #7099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2017
Merged

fix(sidenav-fab-example):removed overflow:auto; since there is no need for it #7099

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f2c99
fix(sidenav-fab-example):removed overflow:auto; since there is no need
FadySamirSadek Sep 15, 2017
8f49757
fix(sidenav-fab-example:Doc)
FadySamirSadek Sep 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/material-examples/sidenav-fab/sidenav-fab-example.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
overflow: visible;
}

.example-scrolling-content {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually needed because the same class is used to make the sidenav content scroll. Actually can you add height: 100% to this instead? That should fix the issue where the FAB button in the content section scrolls up instead of staying fixed:

.example-scrolling-content {
  overflow: auto;
  height: 100%;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you , I fixed it in the next commit

overflow: auto;
}

.example-fab {
position: absolute;
right: 20px;
Expand Down