Skip to content

chore(ripple): no longer update if _matRippleTrigger changes #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017
Merged

chore(ripple): no longer update if _matRippleTrigger changes #7903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/core/ripple/ripple.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export class MatRipple implements OnChanges, OnDestroy {
}

ngOnChanges(changes: SimpleChanges) {
if ((changes['trigger'] || changes['_matRippleTrigger']) && this.trigger) {
if (changes['trigger'] && this.trigger) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to switch this to change.trigger as well.

Copy link
Member Author

@devversion devversion Oct 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. As @jelbourn mentioned, the trigger needs to be a string to avoid closure renaming.

this._rippleRenderer.setTriggerElement(this.trigger);
}

Expand Down