build: enforce that deprecated APIs have a deletion target #9931
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up from angular#9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
googlebot
added
the
cla: yes
crisbeto
commented
Feb 13, 2018
| /** @deprecated Use the animation property instead. */ | ||
| /** | ||
| * @deprecated Use the `animation` property instead. | ||
| * @deletion-target 7.0.0 |
There was a problem hiding this comment.
@devversion not completely sure on the version for this one.
CaerusKaru
added a commit
to angular/flex-layout
that referenced
this pull request
Feb 13, 2018
* Equivalent commit to angular/components#9931
jelbourn
approved these changes
Feb 13, 2018
| /** @deprecated Use the animation property instead. */ | ||
| /** | ||
| * @deprecated Use the `animation` property instead. | ||
| * @deletion-target 7.0.0 |
jelbourn
added
pr: lgtm
action: merge
ThomasBurleson
pushed a commit
to angular/flex-layout
that referenced
this pull request
Feb 17, 2018
* Equivalent commit to angular/components#9931
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Follow-up from #9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #9881. Ensures that anything marked with
@deprecatedalso has a@deletion-target.