This repository was archived by the owner on Dec 18, 2024. It is now read-only.
docs-infra: address numerous a11y issues #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splaktar
requested review from
jelbourn,
crisbeto,
devversion and
andrewseguin
This was referenced Dec 30, 2019
Splaktar
commented
Dec 30, 2019
Splaktar
force-pushed
the
a11y-codelyzer-tslint
branch
from
35c75f3 to
4b339a0
Compare
Splaktar
force-pushed
the
a11y-codelyzer-tslint
branch
2 times, most recently
from
dbf5810 to
f354578
Compare
jelbourn
reviewed
Jan 16, 2020
jelbourn
reviewed
Jan 16, 2020
Splaktar
force-pushed
the
a11y-codelyzer-tslint
branch
from
e759ed2 to
77fbd7b
Compare
- do some merging of tslint:recommended and our rules
enable Codelyzer a11y rules Relates to #671
…n correct element Fixes #693
…prove contrast - use Roboto font instead of system-ui for `docs-nav-content-btn`s - use a different background color for selected route, in addition to different text color - increase opacity of `docs-nav-content-btn`s to meet contrast guidelines - switch to `mat-nav-list` to get the benefits of better contrast and hover/focus styles - plus slightly more padding for touch interfaces Fixes #694. Relates to #671.
- improves screen reader support - footer tags were already properly used Relates to #671.
- so that they can be differentiated by screen readers Relates to #671.
- aria-expanded already covers whether the section can be toggled or not - the button's text content already covers the accessible name Relates to #671.
- the aria-label is sufficient Relates to #671.
- minify theme-demo-icon.svg - use & instead of / as it reads better on a screen reader - prefix classes with `docs-` - tell screen reader users when a theme has been selected Fixes #671
Splaktar
force-pushed
the
a11y-codelyzer-tslint
branch
from
77fbd7b to
419de93
Compare
|
Addressed feedback and also added a LiveAnnouncer message when a theme is selected from the list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commits for descriptions and related issues (#671 captures most, but not all of the issues).
More Accessible Theme Picker
The current theme picker is a
mat-grid-listnested in amat-menuwhich isn't ideal.The new theme picker is a
mat-menuwithbuttonelements.TODO